Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DART_ENABLE_SIMD=OFF by default #1825

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Set DART_ENABLE_SIMD=OFF by default #1825

merged 1 commit into from
Jul 4, 2024

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jul 4, 2024 •
edited
Loading

gazebosim/gz-physics#662

Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

@jslee02
Set DART_ENABLE_SIMD=OFF by default
2d21c25 
Signed-off-by: Jeongseok (JS) Lee <jslee02@users.noreply.github.com>
@jslee02 jslee02 added this to the DART 6.14.3 milestone Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.57%. Comparing base (4138ff2) to head (2d21c25).
Report is 12 commits behind head on release-6.14.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-6.14    #1825   +/-   ##
=============================================
  Coverage         61.56%   61.57%           
=============================================
  Files               490      490           
  Lines             46021    46021           
=============================================
+ Hits              28334    28337    +3     
+ Misses            17687    17684    -3

see 1 file with indirect coverage changes

@jslee02 jslee02 marked this pull request as ready for review July 4, 2024 04:57
@jslee02 jslee02 merged commit aeaa84a into release-6.14 Jul 4, 2024
32 checks passed
@jslee02 jslee02 deleted the jslee02-patch-1 branch July 4, 2024 04:57
@BrewTestBot BrewTestBot mentioned this pull request Jul 5, 2024
Merged
henriquealrs pushed a commit to henriquealrs/dart that referenced this pull request Jul 13, 2024
@jslee02 @henriquealrs
Set DART_ENABLE_SIMD=OFF by default (dartsim#1825)
23b52dd 
Signed-off-by: Jeongseok (JS) Lee <jslee02@users.noreply.github.com>
@mderbaso-deepx
Copy link

Just curious, any performance measurements for this change were made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.14.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jslee02 @mderbaso-deepx @scpeters